Merged
Conversation
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025041703-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests14 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 12 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:14 performance degradations
Remaining performance tests:58 tests
|
This was referenced Mar 28, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
+ Coverage 70.12% 70.37% +0.24%
==========================================
Files 59 61 +2
Lines 12708 12898 +190
==========================================
+ Hits 8912 9077 +165
- Misses 3796 3821 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 4, 2025
marmarek
requested changes
Apr 17, 2025
Member
marmarek
left a comment
marmarek
left a comment
There was a problem hiding this comment.
There are few stylistic issues, but otherwise looks good :)
Comment on lines
1179
to
+1181
| @qubes.events.handler("domain-init", "domain-load") | ||
| def on_domain_init_loaded(self, event): | ||
| # pylint: disable=unused-argument | ||
| if not hasattr(self, "uuid"): | ||
| # pylint: disable=attribute-defined-outside-init | ||
| self.uuid = uuid.uuid4() | ||
| super().on_domain_init_loaded(event) |
Member
There was a problem hiding this comment.
Since this only calls super now, it can be removed.
Member
There was a problem hiding this comment.
Sorry, I missed you added uuid setting in the parent class. It was okay before...
marmarek
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QubesOS/qubes-issues/issues/9015